-
Notifications
You must be signed in to change notification settings - Fork 173
chore: added screenshot testing #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
779cb53
chore: added screenshot testing
kikoso 100a8cf
chore: added GitHub flow integration
kikoso 137121c
chore: upload build report
kikoso 6994060
chore: reset cluster
kikoso 3f1806a
chore: reset cluster
kikoso 5992dbc
chore: reset cluster
kikoso 973c397
chore: added threshold
kikoso 0446902
chore: changed threshold
kikoso fe8f007
chore: changed threshold to 5%
kikoso 6763992
chore: increased version
kikoso e8cac1c
chore: new reference version
kikoso 7afa7c4
chore: changed threshold
kikoso a10594d
chore: changed threshold
kikoso b5ca3bf
chore: changed threshold
kikoso dfd11ba
chore: changed threshold
kikoso 451fac7
chore: added test for DisappearingScaleBar
kikoso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+2.77 KB
...oogle/maps/android/compose/ScaleBarTest/PreviewScaleBar_da39a3ee_da39a3ee_0.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
app/src/screenshotTest/java/com/google/maps/android/compose/ScaleBarTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| package com.google.maps.android.compose | ||
|
|
||
| import androidx.compose.foundation.layout.padding | ||
| import androidx.compose.runtime.Composable | ||
| import androidx.compose.runtime.remember | ||
| import androidx.compose.ui.Modifier | ||
| import androidx.compose.ui.tooling.preview.Preview | ||
| import androidx.compose.ui.unit.dp | ||
| import com.google.android.gms.maps.model.CameraPosition | ||
| import com.google.android.gms.maps.model.LatLng | ||
| import com.google.maps.android.compose.theme.MapsComposeSampleTheme | ||
| import com.google.maps.android.compose.widgets.ScaleBar | ||
|
|
||
|
|
||
| class ScaleBarTest() { | ||
| @Preview | ||
| @Composable | ||
| fun PreviewScaleBar() { | ||
| val cameraPositionState = remember { | ||
| CameraPositionState( | ||
| position = CameraPosition( | ||
| LatLng(48.137154, 11.576124), // Example coordinates: Munich, Germany | ||
| 12f, | ||
| 0f, | ||
| 0f | ||
| ) | ||
| ) | ||
| } | ||
|
|
||
| MapsComposeSampleTheme { | ||
| ScaleBar( | ||
| modifier = Modifier.padding(end = 4.dp), | ||
| cameraPositionState = cameraPositionState | ||
| ) | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.