Change GetCurrentPosters sort logic #1252
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the user is involved in, and then all other posters
Jshmill
changed the title
Jshmill
changed the title
russtuck
requested changes
Jul 18, 2025
Member
russtuck
left a comment
russtuck
left a comment
There was a problem hiding this comment.
I've only read the comment, about a breaking change. Please create a new API endpoint instead, and change the UI to use that one. Mark the old API endpoint as deprecated, but keep it. After both API and UI are pushed, then it will be safe to delete the old API endpoint and push that chane.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend found here: gordon-cs/gordon-360-ui#2747
Changed the logic of getCurrentPosters to sort it like it should be sorted in PosterSwiper. Connected to the frontend pull request.
WARNING! DO NOT MERGE ONE AT A TIME!! This changes the logic for a api call in the frontend, so it will indeed break the frontend!!!