Change GetCurrentPosters sort logic #2747
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jshmill
changed the title
russtuck
requested changes
Jul 31, 2025
Member
russtuck
left a comment
russtuck
left a comment
There was a problem hiding this comment.
I haven't reviewed this, but a breaking API change should be made in steps that don't break. Change the API to provide the new behavior without breaking the existing UI. (Perhaps add new endpoints, if necessary.) Then change the UI to use the new features and not the old. Then change the backend to remove the old.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend here: gordon-cs/gordon-360-api#1252
Changed frontend to fit for Backend changes for getCurrentPoster. Now PosterSwiper sorts by Priority first (CEC), then all the clubs the user is involved in, and finally all the other clubs, not just by expiration date.
WARNING! DO NOT MERGE ONE AT A TIME!! This is based upon a change from the backend, and merging one without the other will break the system!!!