wmr-SRP example for class and minor UI update on MyHall#2614
Open
jtasonye wants to merge 1 commit intowheres-my-rafrom
Open
wmr-SRP example for class and minor UI update on MyHall#2614jtasonye wants to merge 1 commit intowheres-my-rafrom
jtasonye wants to merge 1 commit intowheres-my-rafrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made in PR:
MyHallcomponent. SRP states that a component should have one clear responsibility, but looking at our previous useEffect, it had multiple responsibilities (e.g. string manipulation and updating the statesetRdProfileLink).generateRDProfileLinkis only responsible for the string manipulation to get the profile link and theuseEffectis only responsible for state updates nowMy Assigned Roomstext should only be displayed if the user is an RA, so I made some changes to fix that error