Skip to content

wmr-SRP example for class and minor UI update on MyHall #2614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jtasonye wants to merge 1 commit into
base: wheres-my-ra
Choose a base branch
from
Open

wmr-SRP example for class and minor UI update on MyHall #2614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions src/views/ResLife/components/ResidentView/components/MyHall/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,15 @@ const MyHall = () => {
}
}, [profile]);

// Refactored to follow the Single Responsibility Principle
const generateRDProfileLink = (email) => {
if (!email) return DEFAULT_PROFILE_URL;
const [firstName, lastName] = rdInfo.RD_Email.split('@')[0].split('.');
return DEFAULT_PROFILE_URL + `${firstName}.${lastName}`;
};

useEffect(() => {
if (rdInfo?.RD_Email) {
const [firstName, lastName] = rdInfo.RD_Email.split('@')[0].split('.');
setRdProfileLink(DEFAULT_PROFILE_URL + `${firstName}.${lastName}`);
}
setRdProfileLink(generateRDProfileLink(rdInfo?.RD_Email));
}, [rdInfo]);

// Show loading state if profile is not yet loaded
Expand Down Expand Up @@ -144,7 +148,13 @@ const MyHall = () => {
</Typography>

<Typography variant="body1">
<strong>My Assigned Rooms:</strong> {isRA ? <AssignedRooms /> : <></>}
{isRA ? (
<strong>
My Assigned Rooms: <AssignedRooms />{' '}
</strong>
) : (
<></>
)}
</Typography>
</Grid>

Expand Down
Loading