Skip to content

Conversation

@tippfehlr
Copy link

I have ferium upgrade in my upgrade script and printing all mods every time is unnecessary in my case. I only want to see mods that are actually upgraded.

@T3sT3ro
Copy link

T3sT3ro commented May 24, 2023

-l in this case is confusing for any linux/terminal user, as it's an almost standard for "long list format" or otherwise for "long output", the format that --verbose uses.

--less is an unfortunate naming for all linux users, as it's a standard tool for displaying files in terminal. There are many tools that use --less argument to use less as a pager and it's confusing.

A much better and standardized argument option is -q, --quiet, --silent which suppresses printing to terminal.

@tippfehlr
Copy link
Author

You're right, I didn't think about that (I'm a Linux user myself). Do you think -q/--quiet would be the right choice? The command line flag only suppresses the first part and doesn't print nothing.

@T3sT3ro
Copy link

T3sT3ro commented May 24, 2023

I think I would go with -s --short for the short output like yours and with -q --quiet for no output at all (exit code only).

@tippfehlr tippfehlr force-pushed the ferium-upgrade-less branch from 7c4b16f to 1371522 Compare May 24, 2023 14:48
@tippfehlr tippfehlr changed the title add -l/--less option to ferium upgrade to hide compatible mods add -s/--short option to ferium upgrade to hide compatible mods May 24, 2023
@tippfehlr tippfehlr mentioned this pull request Aug 18, 2023
11 tasks
@theRookieCoder
Copy link
Collaborator

Actually I thought that making this the default, and having a --verbose/-v flag would be more appropriate.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants