Skip to content

Add mailers for org admin alerts#2602

Merged
SamJamCul merged 2 commits intomainfrom
add-mailers-for-org-admin-alerts
Mar 11, 2026
Merged

Add mailers for org admin alerts#2602
SamJamCul merged 2 commits intomainfrom
add-mailers-for-org-admin-alerts

Conversation

@SamJamCul
Copy link
Contributor

@SamJamCul SamJamCul commented Mar 6, 2026

What problem does this pull request solve?

Trello card: https://trello.com/c/FLOb2XJa/2849-add-mailers-for-org-admin-alerts

Adds the Notify templates (which you can find here, and creates mailers that map to them.

Some of the templates are subject to change based on content input, so it might need a bit of tweaking before it goes live.

They are hidden behind the feature flag, because they're not currently in use anywhere. There may be some opportunities to reduce duplication in some of the mailers, but that will be contingent on the pending modifications to the templates.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@SamJamCul SamJamCul force-pushed the add-mailers-for-org-admin-alerts branch 2 times, most recently from 2813409 to 7e65f1b Compare March 6, 2026 11:53
Copy link
Contributor

@stephencdaly stephencdaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some super nitpicky comments about the naming of some methods just because I found them a little confusing to read. Feel free to disagree with them though.

Other than that looks good. I haven't checked all the content in the emails, but I've checked the template IDs match up.

@SamJamCul SamJamCul force-pushed the add-mailers-for-org-admin-alerts branch 6 times, most recently from 0a398f8 to 447fc20 Compare March 6, 2026 13:01
@SamJamCul SamJamCul force-pushed the add-mailers-for-org-admin-alerts branch 4 times, most recently from c0b7d75 to a036604 Compare March 6, 2026 16:00
@stephencdaly stephencdaly force-pushed the add-mailers-for-org-admin-alerts branch from a036604 to 7dbae7f Compare March 10, 2026 14:27
@SamJamCul SamJamCul force-pushed the add-mailers-for-org-admin-alerts branch from 7dbae7f to c125ce4 Compare March 11, 2026 10:19
We'll be introducing a category of alerts for org admins, and these
mailers correspond to Notify templates for those alerts. All the new
alerts being introduced are in this commit.
@SamJamCul SamJamCul force-pushed the add-mailers-for-org-admin-alerts branch from c125ce4 to 979317a Compare March 11, 2026 10:21
@sonarqubecloud
Copy link

@github-actions
Copy link

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2602.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@SamJamCul SamJamCul added this pull request to the merge queue Mar 11, 2026
Merged via the queue into main with commit 9030b2b Mar 11, 2026
6 checks passed
@SamJamCul SamJamCul deleted the add-mailers-for-org-admin-alerts branch March 11, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants