Skip to content

[newchem-cpp] cppify self_shielding_err_check#491

Open
mabruzzo wants to merge 3 commits intograckle-project:newchem-cppfrom
mabruzzo:ncc/cppify-self_shielding_err_check
Open

[newchem-cpp] cppify self_shielding_err_check#491
mabruzzo wants to merge 3 commits intograckle-project:newchem-cppfrom
mabruzzo:ncc/cppify-self_shielding_err_check

Conversation

@mabruzzo
Copy link
Collaborator

@mabruzzo mabruzzo commented Jan 13, 2026

This PR consists of 3 parts:

  1. convert utils.c -> utils.cpp and utils.h -> utils.hpp
    • for context, self_shielding_err_check is the only function defined in the file
  2. rename utils.cpp -> self_shielding_err_check.hpp (and delete utils.hpp)
    • I renamed the file because utils.cpp is not very descriptive and we have another file named utils-cpp.cpp.
    • I made self_shielding_err_check into an inline function because the definition is pretty short
  3. start using clang-format to format self_shielding_err_check.hpp and move self_shielding_err_check into the grackle::impl namespace

@mabruzzo
initial efforts to cppify utils.[ch]
e97fd15
@mabruzzo
Rename utils.cpp -> self_shielding_err_check.hpp (& rm utils.hpp)
6c03474 
I renamed things because utils.cpp is not very descriptive and we have
another file named utils-cpp.cpp. Since this is a really tiny function,
I decided to define it inline
@mabruzzo
start formatting self_shielding_err_check and start put the function …
b68179a 
…inside the internal namespace
@mabruzzo mabruzzo mentioned this pull request Jan 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mabruzzo