[newchem-cpp] Introduce PartMap#493
Open
mabruzzo wants to merge 38 commits intograckle-project:newchem-cppfrom
Open
[newchem-cpp] Introduce PartMap#493mabruzzo wants to merge 38 commits intograckle-project:newchem-cppfrom
PartMap#493mabruzzo wants to merge 38 commits intograckle-project:newchem-cppfrom
Conversation
For context, the gmock library is a component of googletest (it's already being installed). All this commit does is make it possible for us to use it in subsequent PRs
This change ensures that the chemistry_data extension type will provide a consistent set of attributes, even if we make unused rate information inaccessible through the ratequery interface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be reviewed after #474 and #482 are merged
The
PartMapdatatype is building block used in a bunch of other PRs (e.g. #491).I added a bunch of explanation and some example code in the docstrings. I can point to more PRs that use this machinery as I create them