[newchem-cpp] Remove PhotoRxnRateCollection#496
Open
mabruzzo wants to merge 89 commits intograckle-project:newchem-cppfrom
Open
[newchem-cpp] Remove PhotoRxnRateCollection#496mabruzzo wants to merge 89 commits intograckle-project:newchem-cppfrom
PhotoRxnRateCollection#496mabruzzo wants to merge 89 commits intograckle-project:newchem-cppfrom
Conversation
…transcribe_cool1d_cloudy_old_tables_g
for more information, see https://pre-commit.ci
…ub.com/ChristopherBignamini/grackle into newchem-cpp_transcribe_rate_timestep_g
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…transcribe_rate_timestep_g
for more information, see https://pre-commit.ci
…ub.com/ChristopherBignamini/grackle into newchem-cpp_transcribe_rate_timestep_g
for more information, see https://pre-commit.ci
For context, the gmock library is a component of googletest (it's already being installed). All this commit does is make it possible for us to use it in subsequent PRs
…d radiative rates
The change in the names reflect the variable now generically references any standard photo-rate (not just rates adjusted for shielding)
This was separated from the prior commit to make review easier
In the process, I also removed `MiscRxnRateKind_`
This was intentionally separated from the previous commit. No other changes were made in this commit
This was referenced Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be reviewed after #476 and #495 are merged
This PR removes the
PhotoRxnRateCollectionstruct and now tracks each of the computed radiative reaction in an array that is accessed with a Compile-time LUT. Thanks to these changes, the radiative reaction rates are now handled in the same way as all other reaction rates.This is a relatively straight-forward PR. It's probably best to review it commit-by-commit