-
Notifications
You must be signed in to change notification settings - Fork 20
CI: Validate support for Python 3.14 #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Warning Rate limit exceeded@amotl has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 59 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughCI and packaging updated to include Python 3.14; CI install command flags adjusted; dependency upper bounds relaxed; changelog updated; Makefile test-target conditional pytest-install was commented out. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
=======================================
Coverage 84.53% 84.53%
=======================================
Files 9 9
Lines 1138 1138
=======================================
Hits 962 962
Misses 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/tests.yml (1)
28-32: Matrix update to 3.14 looks good; consider an extra mid‑range version and verify action support.Targeting both the floor (
"3.8") and ceiling ("3.14") of your supported range is a sensible compromise given the large Grafana matrix. If CI time permits, you might optionally add one mid‑range CPython (e.g. 3.11/3.12) to catch version‑specific regressions without exploding job count.Also, please confirm that
actions/setup-python@v6andastral-sh/setup-uv@v7currently provide Python 3.14 onubuntu-latest(and update their versions if needed), so the new matrix entry actually resolves to a valid toolchain.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/tests.yml(1 hunks)CHANGES.rst(1 hunks)setup.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: Python 3.14, Grafana 11.5.8
- GitHub Check: Python 3.14, Grafana 11.6.5
- GitHub Check: Python 3.14, Grafana 7.5.17
- GitHub Check: Python 3.14, Grafana 12.1.1
- GitHub Check: Python 3.14, Grafana 8.5.27
- GitHub Check: Python 3.14, Grafana 9.5.21
- GitHub Check: Python 3.14, Grafana 10.4.17
- GitHub Check: Python 3.8, Grafana 11.6.5
- GitHub Check: Python 3.14, Grafana 10.3.12
- GitHub Check: Python 3.14, Grafana 6.7.6
- GitHub Check: docker
🔇 Additional comments (2)
setup.py (1)
68-76: Python 3.14 classifier aligns with CI goals; verify dependency support.Adding
"Programming Language :: Python :: 3.14"is consistent with the CI and changelog updates and keeps classifiers contiguous with 3.8–3.13. I’d keep this, but it’s worth double‑checking that the pinned ranges ininstall_requiresand test extras (e.g.,pandas<2.3,duckdb<1.3,pytest<9,grafanalib==0.7.1) all have releases that actually support Python 3.14, or be prepared to relax bumps as the ecosystem catches up.CHANGES.rst (1)
6-9: Changelog entry matches CI/packaging changes.The new “CI: Validated support for Python 3.14” line is consistent with the workflow and classifier updates and fits the existing changelog style. When you cut the next release, just remember to move this from the “in progress” section into the appropriate dated version block.
... permitting their next minor version series. This will hopefully improve install+build times on Python 3.14.
Just maintenance.