Skip to content

Conversation

@amotl
Copy link
Contributor

@amotl amotl commented Dec 3, 2025

Just maintenance.

@coderabbitai
Copy link

coderabbitai bot commented Dec 3, 2025

Warning

Rate limit exceeded

@amotl has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 59 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 25feee5 and 1b1ff3a.

📒 Files selected for processing (1)
  • .github/workflows/tests.yml (2 hunks)

Summary by CodeRabbit

  • Chores

    • Added Python 3.14 support validation to CI and updated project classifiers.
    • Updated dependency constraints: pandas (<2.4), duckdb (<1.5), and grafana-client (<6).
    • Updated GitHub Actions workflow configuration and installation flags for enhanced compatibility.
  • Documentation

    • Added changelog entry documenting Python 3.14 CI validation support.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

CI and packaging updated to include Python 3.14; CI install command flags adjusted; dependency upper bounds relaxed; changelog updated; Makefile test-target conditional pytest-install was commented out.

Changes

Cohort / File(s) Summary
CI & workflow
.github/workflows/tests.yml
Added Python 3.14 to the GitHub Actions Python matrix; changed project setup step to install with --upgrade and --only-binary=duckdb --only-binary=pandas before --editable='.[test]'.
Changelog
CHANGES.rst
Added line: "CI: Validated support for Python 3.14".
Package metadata
setup.py
Relaxed upper bounds: pandas <2.3<2.4, duckdb <1.3<1.5; loosened grafana-client <5<6; added Programming Language :: Python :: 3.14 classifier.
Build/test target
Makefile
Commented out the conditional that invoked install-tests when pytest was absent from the test target (removed automatic pre-test install check).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Review points:
    • Confirm CI install flags and ordering in .github/workflows/tests.yml.
    • Verify dependency bound changes in setup.py for compatibility.
    • Ensure CHANGES.rst entry placement is correct.
    • Check Makefile change doesn't break CI/test runner expectations.

Poem

🐰 I nibbled YAML, pip flags in paw,
3.14 now watches the CI draw.
Bounds relaxed, changelog penned with care,
A quiet hop — tests run with new air. ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description 'Just maintenance' is vague and generic, using a non-descriptive term that doesn't convey meaningful information about the specific changes made to the codebase. Consider expanding the description to briefly explain what maintenance tasks are being performed, such as 'Updates CI workflows, dependencies, and Python version classifiers to support Python 3.14'.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'CI: Validate support for Python 3.14' directly and clearly describes the main change in the PR, which updates CI workflows, dependencies, and classifiers to support Python 3.14.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.53%. Comparing base (d0066c9) to head (1b1ff3a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #207   +/-   ##
=======================================
  Coverage   84.53%   84.53%           
=======================================
  Files           9        9           
  Lines        1138     1138           
=======================================
  Hits          962      962           
  Misses        176      176           
Flag Coverage Δ
unittests 84.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/tests.yml (1)

28-32: Matrix update to 3.14 looks good; consider an extra mid‑range version and verify action support.

Targeting both the floor ("3.8") and ceiling ("3.14") of your supported range is a sensible compromise given the large Grafana matrix. If CI time permits, you might optionally add one mid‑range CPython (e.g. 3.11/3.12) to catch version‑specific regressions without exploding job count.

Also, please confirm that actions/setup-python@v6 and astral-sh/setup-uv@v7 currently provide Python 3.14 on ubuntu-latest (and update their versions if needed), so the new matrix entry actually resolves to a valid toolchain.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0066c9 and 7048aea.

📒 Files selected for processing (3)
  • .github/workflows/tests.yml (1 hunks)
  • CHANGES.rst (1 hunks)
  • setup.py (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: Python 3.14, Grafana 11.5.8
  • GitHub Check: Python 3.14, Grafana 11.6.5
  • GitHub Check: Python 3.14, Grafana 7.5.17
  • GitHub Check: Python 3.14, Grafana 12.1.1
  • GitHub Check: Python 3.14, Grafana 8.5.27
  • GitHub Check: Python 3.14, Grafana 9.5.21
  • GitHub Check: Python 3.14, Grafana 10.4.17
  • GitHub Check: Python 3.8, Grafana 11.6.5
  • GitHub Check: Python 3.14, Grafana 10.3.12
  • GitHub Check: Python 3.14, Grafana 6.7.6
  • GitHub Check: docker
🔇 Additional comments (2)
setup.py (1)

68-76: Python 3.14 classifier aligns with CI goals; verify dependency support.

Adding "Programming Language :: Python :: 3.14" is consistent with the CI and changelog updates and keeps classifiers contiguous with 3.8–3.13. I’d keep this, but it’s worth double‑checking that the pinned ranges in install_requires and test extras (e.g., pandas<2.3, duckdb<1.3, pytest<9, grafanalib==0.7.1) all have releases that actually support Python 3.14, or be prepared to relax bumps as the ecosystem catches up.

CHANGES.rst (1)

6-9: Changelog entry matches CI/packaging changes.

The new “CI: Validated support for Python 3.14” line is consistent with the workflow and classifier updates and fits the existing changelog style. When you cut the next release, just remember to move this from the “in progress” section into the appropriate dated version block.

... permitting their next minor version series. This will hopefully
improve install+build times on Python 3.14.
@amotl amotl merged commit bf8ed4a into main Dec 3, 2025
23 checks passed
@amotl amotl deleted the python314 branch December 3, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants