-
Notifications
You must be signed in to change notification settings - Fork 9
Update OpenTelemetry package versions #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Item 1 could be an issue for some users even if the packages are compatible. It's not unusual to only allow LTS versions to be deployed. Item 2 I'd vote only publishing a 1.12.x for now. Unfortunately because semantic conventions are still stabilizing, there will continue to be instrumentations with breaking changes like this. If it becomes an issue for users, we will need to see about having OpenTelemetry.Instrumentation.AWS publish multiple versions with the latest OTel SDK and the different versions of the AWS SDK. |
Consume changes from open-telemetry/opentelemetry-dotnet-contrib#2829 for test purposes. Builds on top of #145.
e4c94ad
to
fa47414
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
1bf949e
to
11a6635
Compare
Fixed by setting |
Cherry-pick change from #145 to avoid `ArgumentException` when using v4 of the AWS SDK.
This comment was marked as outdated.
This comment was marked as outdated.
* Run OATS tests using NuGet packages Refactor the OATS tests to consume the built NuGet packages, rather than compiling the distribution from source. * Fix warning Avoid warning when installing OATS by disabling the Go cache. * Bump Swashbuckle.AspNetCore Bump Swashbuckle.AspNetCore to the latest release. * Avoid ArgumentException Cherry-pick change from #145 to avoid `ArgumentException` when using v4 of the AWS SDK.
9f0e7b2
to
b56da50
Compare
@matt-hensley Thoughts on what to do with this PR? Possible options:
If 1, we can have a chat about what things we might want to do before shipping an updated version to NuGet.org. |
My preference is the first option (go ahead and merge) and cut a release soon. Sorting out .NET Framework support both upstream and in our distro will take some time / can come later. |
Cool - in that case unless there's anything specific you're aware of, then I just want to sort out the releasing-from-GitHub stuff we talked about a few weeks ago where we need to get the API key into secrets. |
Disable until I can work out why we don't see it.
- Rearrange the groups to match the comments. - Use `GetTargetFrameworkIdentifier()` intrinsic for conditions. - Use `Label` attribute instead of comments.
Update to the v4 AWS SDK.
Update more NuGet packages to their latest versions.
Allow duplicate spans called `main` to account for database creation and then the query.
Metrics become opt-in in 1.10.0-beta.1 and changed name.
Add CHANGELOG entries for this pull request.
eb55586
to
cbdedb3
Compare
- Move OpenTelemetry.Instrumentation.AspNetCore to the right group. - Remove `OpenTelemetry.Instrumentation.MySqlData` accidentally re-added during rebase.
Copy over relevant changes from upstream.
Bump AWSSDK.S3 to the latest version.
- Bump OpenTelemetry.Instrumentation.StackExchangeRedis to 1.12.0-beta.2. - Bump Microsoft.Data.SqlClient to 6.1.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates OpenTelemetry NuGet packages to their latest versions (primarily 1.12.0) to resolve security vulnerabilities and dependency issues. The update includes upgrading from beta versions to stable releases, introducing .NET 9 dependencies, and modernizing package references.
Key Changes
- Upgrade OpenTelemetry packages from 1.9.0/1.10.0-beta to 1.12.0
- Update AWS SDK from v3 to v4 (breaking change)
- Enable SQL Client metrics instrumentation
- Reorganize and simplify project file structure with better labeling
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
src/Grafana.OpenTelemetry/Grafana.OpenTelemetry.csproj | Major package version updates and restructured dependency groups |
src/Grafana.OpenTelemetry.Base/Grafana.OpenTelemetry.Base.csproj | Updated core OpenTelemetry packages and reorganized instrumentation references |
src/Grafana.OpenTelemetry.Base/Instrumentations/SqlClientInitializer.cs | Added metrics initialization for SQL Client instrumentation |
src/Grafana.OpenTelemetry.Base/GrafanaOpenTelemetryEventSource.cs | Made Log field readonly for thread safety |
examples/net8.0/aspnetcore/aspnetcore.csproj | Updated AWS SDK and SQL Client package versions |
docker/docker-compose-aspnetcore/oats.yaml | Added new metrics expectations and updated trace attribute names |
CHANGELOG.md | Comprehensive documentation of breaking changes and new features |
Fix-up CHANGELOG. Co-authored-by: Copilot <[email protected]>
Add entry for 2763cd6.
Changes
Update OpenTelemetry (and test) NuGet packages to their latest versions.
This raises a few questions:
Microsoft.Extensions.*
dependencies are forced onto .NET 8 applications ([bug] Instrumentation packages reference .NET 9 framework assemblies open-telemetry/opentelemetry-dotnet-contrib#2361).Merge requirement checklist
CHANGELOG.md
file updated for non-trivial changes