-
Notifications
You must be signed in to change notification settings - Fork 9
Use aspnet image in example/OATS #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Fix running in the sdk image instead of aspnet. - Use chiselled container to reduce size.
SqlClient doesn't work with invariant mode.
Appears to need extra setup for SQL Server to work.
- Update to latest .NET 8 SDK and runtime. - Pin dotnet/aspnet container by SHA.
Configure dependabot to update the .NET 8 SDK in global.json and in the Dockerfile.
be18505 to
5d56aea
Compare
| @@ -1,5 +1,25 @@ | |||
| version: 2 | |||
| updates: | |||
| - package-ecosystem: "docker" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
migrating to renovate is really easy now too: https://enghub.grafana-ops.net/docs/default/component/application-security-documentation/appsec-tools/how-to-configure-renovate/#instructions-for-public-repositories
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge this now, then remove dependabot once renovate is setup.
Changes
Fix running in the
sdkimage instead ofaspnet.On my laptop the container size goes down from 1.3GB to ~360MB.
Merge requirement checklist
CHANGELOG.mdfile updated for non-trivial changes