-
Notifications
You must be signed in to change notification settings - Fork 9
Bump OpenTelemetry NuGet packages to v1.14 #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates various NuGet packages to their latest versions across the Grafana OpenTelemetry .NET SDK project.
- Updates OpenTelemetry instrumentation packages from 1.12.0 to 1.12.1 and beta versions to newer beta releases
- Updates third-party dependencies including AWS SDK, Entity Framework Core, and Swashbuckle
- Updates Microsoft Data SqlClient to the latest version
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Grafana.OpenTelemetry/Grafana.OpenTelemetry.csproj | Updates OpenTelemetry AWS and AspNet instrumentation packages to newer versions |
| src/Grafana.OpenTelemetry.Base/Grafana.OpenTelemetry.Base.csproj | Updates OpenTelemetry SqlClient instrumentation package to newer beta version |
| examples/net8.0/aspnetcore/aspnetcore.csproj | Updates example project dependencies including AWS SDK, Entity Framework Core, and Swashbuckle |
3540c04 to
3db491c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
89fd164 to
7a05da3
Compare
|
@matt-hensley Should we merge and publish this, or wait for some more upstream OTel changes to accumulate first? |
|
Lean towards waiting and letting 1.13.0 bake some more. The current version works and next one doesn't have critical bug fixes (yet). |
|
Cool - have put this back into draft and can keep it fresh as new releases ship. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
887d50f to
4308917
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
|
Just need the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Update NuGet packages to their latest versions.
Update to latest packages.
eb6085a to
bac81da
Compare
Initial updates for 1.14.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Apply fixes for comments from Copilot.
Add remaining changes for 1.14.*.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
src/Grafana.OpenTelemetry.Base/Grafana.OpenTelemetry.Base.csproj
Outdated
Show resolved
Hide resolved
|
Just waiting on the packages for open-telemetry/opentelemetry-dotnet-contrib#3519 to be published to update, then this should be ready to merge. |
Update to latest 1.14.* packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Changes
Update OpenTelemetry NuGet packages to v1.14.*.
Merge requirement checklist
Unit tests added/updatedCHANGELOG.mdupdatedChanges in public API reviewed (if applicable)