chore(controllers): Test CR deletion, Update finalizer behaviour of Dashboard, Datasource, and Folder #2098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baarsgaard
changed the base branch from
master
to
chore_test_synchronized_conditions
Baarsgaard
changed the title
Baarsgaard
force-pushed
the
chore_test_synchronized_conditions
branch
from
879c658 to
1e3c7b4
Compare
Baarsgaard
force-pushed
the
test_finalizers
branch
from
4d84f15 to
8df143f
Compare
Baarsgaard
force-pushed
the
chore_test_synchronized_conditions
branch
from
1e3c7b4 to
cb1ce9d
Compare
Baarsgaard
force-pushed
the
test_finalizers
branch
from
8df143f to
6de5874
Compare
Baarsgaard
force-pushed
the
test_finalizers
branch
from
6de5874 to
9d15d89
Compare
Baarsgaard
force-pushed
the
test_finalizers
branch
from
942acbc to
761c95d
Compare
Baarsgaard
force-pushed
the
test_finalizers
branch
from
53420b0 to
40beff8
Compare
Baarsgaard
changed the title
Baarsgaard
requested review from
nissessenap,
weisdd,
ishanjainn,
theSuess,
hubeadmin and
pb82
as code owners
weisdd
approved these changes
Aug 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial goal was to just delete created CRs and trigger the finalizer.
Unfortunately
GrafanaDashboard,GrafanaDatasource, andGrafanaFolderall returned successful when attempting to finalize against thedummyGrafana instance used to provoke Synchronization failures.I removed the early exit in favour of attempting and potentially failing to delete the resource.
All finalizers will now return a success if the resource was deleted or didn't exist, and an error otherwise.
This should lead to a few more requests when finalizing resources, but more correct deletion outcomes in edge cases.
The downside of this is the need to expect an error when the
dummyinstance, which never responds, is being deleted from.