Skip to content

Conversation

MoonBoi9001
Copy link
Member

Motivation:

Title:

N-10 Redundant Return Values

Details:

Throughout the codebase, multiple instances of functions with unused return values were identified:

The _closeAllocation function of the AllocationManager contract
The presentPOI, clearPendingRewards, close, and snapshotRewards functions of the Allocation library
Consider removing these unused return values to simplify the code and improve readability, ensuring that functions only return values that are actively utilized by their callers.

Key changes

  • Removed the unused return value for the the _closeAllocation function of the AllocationManager contract.
  • Removed the unused return value for the the presentPOI, clearPendingRewards, close, and snapshotRewards functions function of the Allocation library.

@MoonBoi9001 MoonBoi9001 requested a review from tmigone September 18, 2024 17:13
Copy link

fix: remove unused return values. (OZ N-10)

Generated at commit: bd62e959dadf8b011b7d3cf766d2cf1103b50120

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
4
0
15
41
62
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link
Member

@tmigone tmigone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️

@MoonBoi9001 MoonBoi9001 merged commit 54286e3 into horizon Sep 19, 2024
7 checks passed
@MoonBoi9001 MoonBoi9001 deleted the fix_oz_n-10 branch September 19, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants