Skip to content

fix: remove unused return values. (OZ N-10) #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2024
Merged

fix: remove unused return values. (OZ N-10) #1040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dfb8b0
fix: remove unused return value. (OZ N-10)
MoonBoi9001 Sep 18, 2024
bd62e95
fix: remove unused return values from the Allocation library. (OZ N-10)
MoonBoi9001 Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 4 additions & 15 deletions packages/subgraph-service/contracts/libraries/Allocation.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,10 @@ library Allocation {
* @param self The allocation list mapping
* @param allocationId The allocation id
*/
function presentPOI(mapping(address => State) storage self, address allocationId) internal returns (State memory) {
function presentPOI(mapping(address => State) storage self, address allocationId) internal {
State storage allocation = _get(self, allocationId);
require(allocation.isOpen(), AllocationClosed(allocationId, allocation.closedAt));
allocation.lastPOIPresentedAt = block.timestamp;

return allocation;
}

/**
Expand All @@ -116,12 +114,10 @@ library Allocation {
mapping(address => State) storage self,
address allocationId,
uint256 accRewardsPerAllocatedToken
) internal returns (State memory) {
) internal {
State storage allocation = _get(self, allocationId);
require(allocation.isOpen(), AllocationClosed(allocationId, allocation.closedAt));
allocation.accRewardsPerAllocatedToken = accRewardsPerAllocatedToken;

return allocation;
}

/**
Expand All @@ -131,15 +127,10 @@ library Allocation {
* @param self The allocation list mapping
* @param allocationId The allocation id
*/
function clearPendingRewards(
mapping(address => State) storage self,
address allocationId
) internal returns (State memory) {
function clearPendingRewards(mapping(address => State) storage self, address allocationId) internal {
State storage allocation = _get(self, allocationId);
require(allocation.isOpen(), AllocationClosed(allocationId, allocation.closedAt));
allocation.accRewardsPending = 0;

return allocation;
}

/**
Expand All @@ -149,12 +140,10 @@ library Allocation {
* @param self The allocation list mapping
* @param allocationId The allocation id
*/
function close(mapping(address => State) storage self, address allocationId) internal returns (State memory) {
function close(mapping(address => State) storage self, address allocationId) internal {
State storage allocation = _get(self, allocationId);
require(allocation.isOpen(), AllocationClosed(allocationId, allocation.closedAt));
allocation.closedAt = block.timestamp;

return allocation;
}

/**
Expand Down
3 changes: 1 addition & 2 deletions packages/subgraph-service/contracts/utilities/AllocationManager.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ abstract contract AllocationManager is EIP712Upgradeable, GraphDirectory, Alloca
*
* @param _allocationId The id of the allocation to be closed
*/
function _closeAllocation(address _allocationId) internal returns (Allocation.State memory) {
function _closeAllocation(address _allocationId) internal {
Allocation.State memory allocation = allocations.get(_allocationId);

// Take rewards snapshot to prevent other allos from counting tokens from this allo
Expand All @@ -414,7 +414,6 @@ abstract contract AllocationManager is EIP712Upgradeable, GraphDirectory, Alloca
allocation.tokens;

emit AllocationClosed(allocation.indexer, _allocationId, allocation.subgraphDeploymentId, allocation.tokens);
return allocations[_allocationId];
}

/**
Expand Down