Event order #37
Merged
Event order #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikgraf
force-pushed
the
events-order
branch
from
38f8337 to
e663361
Compare
cmwhited
approved these changes
Nov 13, 2024
| data: { | ||
| spaceId, | ||
| counter: lastEvent.counter + 1, | ||
| event: JSON.stringify(event), |
There was a problem hiding this comment.
Should we use canonicalize here? Not sure it is necessary, or if we just need the JSON event object
There was a problem hiding this comment.
In this case we need to JSON.parse the event to forward it to other participants
| } | ||
| }); | ||
|
|
||
| it('should fail in case state is not provided for an event other thant createSpace', async () => { |
There was a problem hiding this comment.
nitpick. typo: thant -> than
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: applyEvent on the server is not yet used. Next up will implement adding an invitation and use it there.
Resolves: #35