-
Notifications
You must be signed in to change notification settings - Fork 8
Event order #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Event order #37
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
25 changes: 25 additions & 0 deletions
25
...risma/migrations/20241113083927_introduce_counter_and_state_to_space_events/migration.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
/* | ||
Warnings: | ||
|
||
- Added the required column `counter` to the `SpaceEvent` table without a default value. This is not possible if the table is not empty. | ||
- Added the required column `state` to the `SpaceEvent` table without a default value. This is not possible if the table is not empty. | ||
|
||
*/ | ||
-- RedefineTables | ||
PRAGMA defer_foreign_keys=ON; | ||
PRAGMA foreign_keys=OFF; | ||
CREATE TABLE "new_SpaceEvent" ( | ||
"id" TEXT NOT NULL PRIMARY KEY, | ||
"event" TEXT NOT NULL, | ||
"state" TEXT NOT NULL, | ||
"counter" INTEGER NOT NULL, | ||
"spaceId" TEXT NOT NULL, | ||
"createdAt" DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP, | ||
CONSTRAINT "SpaceEvent_spaceId_fkey" FOREIGN KEY ("spaceId") REFERENCES "Space" ("id") ON DELETE RESTRICT ON UPDATE CASCADE | ||
); | ||
INSERT INTO "new_SpaceEvent" ("event", "id", "spaceId") SELECT "event", "id", "spaceId" FROM "SpaceEvent"; | ||
DROP TABLE "SpaceEvent"; | ||
ALTER TABLE "new_SpaceEvent" RENAME TO "SpaceEvent"; | ||
CREATE UNIQUE INDEX "SpaceEvent_spaceId_counter_key" ON "SpaceEvent"("spaceId", "counter"); | ||
PRAGMA foreign_keys=ON; | ||
PRAGMA defer_foreign_keys=OFF; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
import { Effect, Exit } from 'effect'; | ||
import type { SpaceEvent } from 'graph-framework-space-events'; | ||
import { applyEvent } from 'graph-framework-space-events'; | ||
import { prisma } from '../prisma.js'; | ||
|
||
type Params = { | ||
accountId: string; | ||
spaceId: string; | ||
event: SpaceEvent; | ||
}; | ||
|
||
export async function applySpaceEvent({ accountId, spaceId, event }: Params) { | ||
return await prisma.$transaction(async (transaction) => { | ||
if (event.transaction.type === 'create-space') { | ||
throw new Error('applySpaceEvent does not support create-space events.'); | ||
} | ||
|
||
// verify that the account is a member of the space | ||
// TODO verify that the account is a admin of the space | ||
await transaction.space.findUniqueOrThrow({ | ||
where: { id: spaceId, members: { some: { id: accountId } } }, | ||
}); | ||
|
||
const lastEvent = await transaction.spaceEvent.findFirstOrThrow({ | ||
where: { spaceId }, | ||
orderBy: { counter: 'desc' }, | ||
}); | ||
|
||
const result = await Effect.runPromiseExit(applyEvent({ event })); | ||
if (Exit.isFailure(result)) { | ||
throw new Error('Invalid event'); | ||
} | ||
|
||
return await transaction.spaceEvent.create({ | ||
data: { | ||
spaceId, | ||
counter: lastEvent.counter + 1, | ||
event: JSON.stringify(event), | ||
id: event.transaction.id, | ||
state: JSON.stringify(result.value), | ||
}, | ||
}); | ||
}); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use
canonicalize
here? Not sure it is necessary, or if we just need the JSON event objectThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case we need to JSON.parse the event to forward it to other participants