fix cli build #443
Merged
fix cli build #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a CLI build issue by ensuring the package.json includes the type field when copying package configuration for the create-hypergraph CLI tool.
- Adds the
typefield from the source package.json to the generated package.json - Reorganizes imports for better consistency
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/create-hypergraph/scripts/copy-package-json.ts | Adds type field to copied package.json and reorganizes imports |
| .changeset/eighty-terms-film.md | Documents the CLI build fix in changeset |
| 'create-hypergraph': 'bin.js', | ||
| ch: 'bin.js', | ||
| }, | ||
| type: json.type, |
There was a problem hiding this comment.
The type field is being copied without validation. If json.type is undefined, this will add type: undefined to the package.json, which could cause issues. Consider adding a conditional check or default value.
Suggested change
| type: json.type, | |
| ...(json.type ? { type: json.type } : {}), |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.