Skip to content

fix cli build #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2025
Merged

fix cli build #443

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a16e5cf
copy package.json type to fix the cli build
nikgraf Aug 7, 2025
68e0011
fix cli build by including type module in package.json
nikgraf Aug 7, 2025
70ca9c7
fix lint
nikgraf Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/eighty-terms-film.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"create-hypergraph": patch
---

fix cli build by including type module in package.json

5 changes: 3 additions & 2 deletions apps/create-hypergraph/scripts/copy-package-json.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as path from 'node:path';
import * as FileSystem from '@effect/platform/FileSystem';
import * as NodeFileSystem from '@effect/platform-node/NodeFileSystem';
import * as FileSystem from '@effect/platform/FileSystem';
import { Effect, pipe } from 'effect';
import * as path from 'node:path';

const read = pipe(
FileSystem.FileSystem,
Expand All @@ -15,6 +15,7 @@ const read = pipe(
'create-hypergraph': 'bin.js',
ch: 'bin.js',
},
type: json.type,
Copy link

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type field is being copied without validation. If json.type is undefined, this will add type: undefined to the package.json, which could cause issues. Consider adding a conditional check or default value.

Suggested change
type: json.type,
...(json.type ? { type: json.type } : {}),

Copilot uses AI. Check for mistakes.

engines: json.engines,
repository: json.repository,
license: json.license,
Expand Down
Loading