add dips graphql #331
add dips graphql #331
Conversation
mangas
force-pushed
the
dips-graphql
branch
2 times, most recently
from
1c724c9 to
ab06867
Compare
Pull Request Test Coverage Report for Build 11707736076Details
💛 - Coveralls |
mangas
force-pushed
the
dips-graphql
branch
3 times, most recently
from
2c3a2ec to
4a514e9
Compare
mangas
force-pushed
the
dips-graphql
branch
6 times, most recently
from
72ebe2c to
e2359ab
Compare
mangas
force-pushed
the
dips-graphql
branch
5 times, most recently
from
2c49fc1 to
bd31868
Compare
mangas
force-pushed
the
dips-graphql
branch
4 times, most recently
from
641ad4d to
2fbf0c3
Compare
mangas
force-pushed
the
dips-graphql
branch
10 times, most recently
from
c2c60c6 to
af6a0ff
Compare
| // should only be usable within a limited period of time. | ||
| uint64 timestamp; |
There was a problem hiding this comment.
I have followed the thread, and it is used in the cancellation request validation. What's the goal of this timestamp?
There was a problem hiding this comment.
essentially to prevent re-use or any variation of that.
| sqlx::query!( | ||
| "UPDATE dips_agreements SET updated_at=now(), cancelled_at=now(), signed_cancellation_payload=$1 WHERE id=$2", | ||
| bs, | ||
| id, | ||
| ) | ||
| .execute(&self.pool) | ||
| .await?; |
There was a problem hiding this comment.
I would return an error when there's no agreement in the DB with the provided ID. If I am correct, the query will not update anything and will return successfully.
There was a problem hiding this comment.
Isn't that the correct outcome anyway? If the query doesn't update anything it's a noop. I don't have a strong preference, if you do I'll change it otherwise I think I'll leave that in for the moment
| // data should be the signed voucher, eip712 signed, rlp and base64 encoded. | ||
| signed_request: String, | ||
| ) -> FieldResult<String> { | ||
| let store: &Arc<dyn AgreementStore> = ctx.data()?; |
There was a problem hiding this comment.
Out of curiosity. Why did you choose dynamic dispatch over a generic argument?
There was a problem hiding this comment.
Normally I find it easier to work with dynamic dispatch, generic arguments tend to propagate through the code very easily, I don't think the perf penalty on something like this is worth the trade-off.
mangas
force-pushed
the
dips-graphql
branch
2 times, most recently
from
3612be8 to
d843fa7
Compare
3 participants
BEGIN_COMMIT_OVERRIDE
chore: add dips graphql
END_COMMIT_OVERRIDE