Skip to content

Conversation

@gusinacio
Copy link
Contributor

@gusinacio gusinacio commented Oct 29, 2024

The last PR was merged, but we still don't have it enabled in indexer-agent. Disabling for now

@gusinacio gusinacio requested a review from anirudh2 October 29, 2024 21:10
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio gusinacio force-pushed the disable-value-check branch from 5d4f1fc to cf9a567 Compare October 29, 2024 21:12
@coveralls
Copy link

coveralls commented Oct 29, 2024

Pull Request Test Coverage Report for Build 11582541711

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.03%) to 74.342%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/tap.rs 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
common/src/tap/checks/deny_list_check.rs 1 98.21%
common/src/tap.rs 1 0.0%
Totals Coverage Status
Change from base Build 11582240500: -0.03%
Covered Lines: 5195
Relevant Lines: 6988

💛 - Coveralls

@gusinacio gusinacio self-assigned this Oct 29, 2024
@gusinacio gusinacio requested a review from carlosvdr October 29, 2024 22:23
@gusinacio gusinacio merged commit eb31981 into main Oct 29, 2024
10 checks passed
@gusinacio gusinacio deleted the disable-value-check branch October 29, 2024 23:13
@github-actions github-actions bot mentioned this pull request Oct 29, 2024
gusinacio added a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants