Skip to content

Conversation

@gusinacio
Copy link
Contributor

No description provided.

@gusinacio gusinacio requested a review from carlosvdr October 30, 2024 00:30
@gusinacio gusinacio linked an issue Oct 30, 2024 that may be closed by this pull request
@gusinacio gusinacio force-pushed the gustavo/tap-231-tap-agent-taking-too-long-to-start-up branch from 1b321c6 to 4b20863 Compare October 30, 2024 00:33
@github-actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 11584749506

Details

  • 15 of 16 (93.75%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 74.601%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/agent/sender_accounts_manager.rs 8 9 88.89%
Totals Coverage Status
Change from base Build 11583997154: 0.05%
Covered Lines: 5231
Relevant Lines: 7012

💛 - Coveralls

Copy link
Contributor

@carlosvdr carlosvdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice!

.await?;
}
.map(|allocation_id| state.create_sender_allocation(myself.clone(), allocation_id))
.buffered(10) // Limit concurrency to 10 allocations at a time
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can be used buffered_unordered

@gusinacio gusinacio merged commit a0ed7b2 into main Oct 30, 2024
10 checks passed
@gusinacio gusinacio deleted the gustavo/tap-231-tap-agent-taking-too-long-to-start-up branch October 30, 2024 02:06
@github-actions github-actions bot mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tap-agent taking too long to start up

3 participants