Skip to content

perf: create allocations in parallel #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2024
Merged

perf: create allocations in parallel #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tap-agent/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ tap_aggregator = { git = "https://github.com/semiotic-ai/timeline-aggregation-pr
ractor = { version = "0.9", features = [
"async-trait",
], default-features = false }
futures = { version = "0.3.30", default-features = false }

[dev-dependencies]
tempfile = "3.8.0"
wiremock = "0.6.1"
futures = { version = "0.3.30", default-features = false }
13 changes: 8 additions & 5 deletions tap-agent/src/agent/sender_account.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ use alloy::primitives::U256;
use bigdecimal::num_bigint::ToBigInt;
use bigdecimal::ToPrimitive;

use futures::{stream, StreamExt};
use graphql_client::GraphQLQuery;
use jsonrpsee::http_client::HttpClientBuilder;
use prometheus::{register_gauge_vec, register_int_gauge_vec, GaugeVec, IntGaugeVec};
Expand Down Expand Up @@ -580,12 +581,14 @@ impl Actor for SenderAccount {
config,
};

for allocation_id in &allocation_ids {
stream::iter(allocation_ids)
// Create a sender allocation for each allocation
state
.create_sender_allocation(myself.clone(), *allocation_id)
.await?;
}
.map(|allocation_id| state.create_sender_allocation(myself.clone(), allocation_id))
.buffered(10) // Limit concurrency to 10 allocations at a time
Copy link
Contributor Author

@gusinacio gusinacio Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can be used buffered_unordered

.collect::<Vec<anyhow::Result<()>>>()
.await
.into_iter()
.collect::<anyhow::Result<Vec<()>>>()?;

tracing::info!(sender = %sender_id, "SenderAccount created!");
Ok(state)
Expand Down
16 changes: 10 additions & 6 deletions tap-agent/src/agent/sender_accounts_manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ use alloy::primitives::Address;
use anyhow::Result;
use anyhow::{anyhow, bail};
use eventuals::{Eventual, EventualExt, PipeHandle};
use futures::{stream, StreamExt};
use indexer_common::escrow_accounts::EscrowAccounts;
use indexer_common::prelude::{Allocation, SubgraphClient};
use ractor::{Actor, ActorCell, ActorProcessingErr, ActorRef, SupervisionEvent};
Expand Down Expand Up @@ -160,12 +161,15 @@ impl Actor for SenderAccountsManager {
}
};

for (sender_id, allocation_ids) in sender_allocation {
state.sender_ids.insert(sender_id);
state
.create_or_deny_sender(myself.get_cell(), sender_id, allocation_ids)
.await;
}
state.sender_ids.extend(sender_allocation.keys());

stream::iter(sender_allocation)
.map(|(sender_id, allocation_ids)| {
state.create_or_deny_sender(myself.get_cell(), sender_id, allocation_ids)
})
.buffered(10) // Limit concurrency to 10 senders at a time
.collect::<Vec<()>>()
.await;

// Start the new_receipts_watcher task that will consume from the `pglistener`
// after starting all senders
Expand Down
Loading