use new join service for host joins#59778
Merged
Conversation
nklaassen
added
no-changelog
avatus
approved these changes
Sep 30, 2025
marcoandredinis
approved these changes
Oct 1, 2025
lib/auth/join/join.go
Outdated
| // | ||
| // Deprecated: this function is superceded by lib/join/joinclient.Join | ||
| // | ||
| // TODO(nklaassen): DELETE IN 19.0.0 |
Contributor
There was a problem hiding this comment.
master is v19, right?
So, according to the comment we should just delete this
However, what do you think about keeping this for at least one more release?
Or keep it behind a feature flag.
We can discuss it when actually removing it, but this seems to be a pretty important part to just remove it without keeping a way to add it back for at least one major release.
Contributor
Author
There was a problem hiding this comment.
theoretically as long as the new join service is fully supported by v19 then we can delete this on the client side in 19.0, but I can't delete it yet because it doesn't support all join methods yet.
But it should be fine to keep it as a fallback on the client side until 20, since v19 servers will still support it, I'll update the DELETE IN comment
nklaassen
force-pushed
the
nklaassen/bots-join
branch
from
d3ab23c to
1a2429e
Compare
nklaassen
force-pushed
the
nklaassen/hosts-join
branch
from
82c2d20 to
7c4364c
Compare
nklaassen
force-pushed
the
nklaassen/bots-join
branch
from
1a2429e to
2a0548a
Compare
nklaassen
force-pushed
the
nklaassen/hosts-join
branch
from
7c4364c to
c7925ab
Compare
nklaassen
force-pushed
the
nklaassen/bots-join
branch
from
2a0548a to
29d94d0
Compare
nklaassen
force-pushed
the
nklaassen/hosts-join
branch
from
c7925ab to
b4b9e3e
Compare
nklaassen
force-pushed
the
nklaassen/bots-join
branch
from
29d94d0 to
0606036
Compare
nklaassen
force-pushed
the
nklaassen/hosts-join
branch
from
f6afd29 to
8560f7e
Compare
nklaassen
force-pushed
the
nklaassen/hosts-join
branch
from
7ca8f92 to
00605da
Compare
Contributor
|
@nklaassen See the table below for backport results.
|
nklaassen
added a commit
that referenced
this pull request
Oct 15, 2025
Backport #59778 to branch/v18
nklaassen
added a commit
that referenced
this pull request
Oct 16, 2025
Backport #59778 to branch/v18
nklaassen
added a commit
that referenced
this pull request
Oct 20, 2025
Backport #59778 to branch/v18
mmcallister
pushed a commit
that referenced
this pull request
Nov 6, 2025
* use new join service for host joins * fall back to legacy join on connection errors
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 13, 2025
* [v18] use new join service for bot joins Backport #59550 to branch/v18 * [v18] use new join service for host joins Backport #59778 to branch/v18 * [v18] heal instance identity by re-joining via new join service Backport #59872 to branch/v18 * use set from utils package in v18 * [v18] fix: keep instance host ID when healing identity Backport #60706 to branch/v18 * [v18] avoid join fallback attempts on legitimate join failure Backport #60673 to branch/v18 * [v18] fix: deflake connection problem detection during joining Backport #60896 to branch/v18 --------- Co-authored-by: Forrest <30576607+fspmarshall@users.noreply.github.com>
mmcallister
pushed a commit
that referenced
this pull request
Nov 19, 2025
* use new join service for host joins * fall back to legacy join on connection errors
mmcallister
pushed a commit
that referenced
this pull request
Nov 20, 2025
* use new join service for host joins * fall back to legacy join on connection errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the host join process in lib/service/connect.go to call the new
lib/join/joinclient.Joininstead of the legacylib/auth/join.Register. This will attempt to use the new join service being implemented as part of RFD 27e where the Auth service noaw assigns the host UUID instead of allowing the joining agent to choose it. Currently only thetokenandbound_keypairmethods are supported by the new join service, for all other join methods or when connecting to older auth servers without the new join service the implementation will fall back to joining via the legacy service.