Skip to content

fix: add useIsomorphicLayoutEffect to fix SSR warnings #2503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+26 −11
Open

fix: add useIsomorphicLayoutEffect to fix SSR warnings #2503

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a39e81
fix(ThemeProvider): add `useIsomorphicLayoutEffect` to fix SSR warnings
monochromer Nov 17, 2025
383e1f6
fix: replace useLayoutEffect to isomoprhic version
monochromer Nov 18, 2025
9ec9922
fix: use relative paths
monochromer Nov 19, 2025
1489fa6
Merge branch 'main' into isomorphic-theme-provider
monochromer Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/theme/ThemeProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import * as React from 'react';

import {useIsomorphicLayoutEffect} from '../../hooks/private';
import {PrivateLayoutProvider} from '../layout/LayoutProvider/LayoutProvider';
import type {PrivateLayoutProviderProps} from '../layout/LayoutProvider/LayoutProvider';
import {block} from '../utils/cn';
Expand Down Expand Up @@ -66,7 +67,7 @@ export function ThemeProvider({

const prevRootClassName = React.useRef('');

React.useLayoutEffect(() => {
useIsomorphicLayoutEffect(() => {
if (!scoped) {
updateBodyClassName({
theme: themeValue,
Expand Down
1 change: 1 addition & 0 deletions src/hooks/private/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,4 @@ export * from './usePrevious';
export * from './useRadio';
export * from './useRadioGroup';
export * from './useUpdateEffect';
export * from './useIsomorphicLayoutEffect';
1 change: 1 addition & 0 deletions src/hooks/private/useIsomorphicLayoutEffect/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export {useIsomorphicLayoutEffect} from './useIsomorphicLayoutEffect';
4 changes: 4 additions & 0 deletions src/hooks/private/useIsomorphicLayoutEffect/useIsomorphicLayoutEffect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import * as React from 'react';

export const useIsomorphicLayoutEffect =
typeof window !== 'undefined' ? React.useLayoutEffect : React.useEffect;
Loading