Skip to content

gpnf-limit-entry-min-max-from-field.php: Fixed an issue with the snippet not working correctly on form load. #1066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025
Merged

gpnf-limit-entry-min-max-from-field.php: Fixed an issue with the snippet not working correctly on form load. #1066

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gp-nested-forms/gpnf-limit-entry-min-max-from-field.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ public function output_script() {
var $maxField = $( '#' + maxFieldId );
var value = parseInt($maxField.val());

return value ? value : self.defaultMax;
return isNaN(value) ? Infinity : (value || self.defaultMax);
Copy link

@coderabbitai coderabbitai bot Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Logic improvement to prevent premature "maximum number reached" message.

The change correctly addresses the issue by checking if the parsed value is not a number (NaN) and returning Infinity in that case. This prevents the system from incorrectly defaulting to a maximum of 0 when the max field is empty, allowing users to add entries without encountering the premature "maximum number reached" message.

This fix resolves the critical issue described in the PR where users couldn't add child entries because the system was incorrectly displaying the maximum limit message when the form loaded.

});

gform.addAction( 'gform_input_change', function( el, formId, fieldId ) {
Expand Down
Loading