Avoid triggering an exception (GCI12) #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue where the rule "@creedengo/no-multiple-style-changes" would trigger an exception when linting code without an expression (common in Next server code). The changes include refactoring a helper function to an arrow function, updating the de-duplication condition logic, improving test case formatting, and adding a corresponding changelog entry.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| eslint-plugin/lib/rules/no-multiple-style-changes.js | Refactored helper function and de-duplication logic to avoid exceptions |
| CHANGELOG.md | Added changelog entry documenting the GCI12 fix |
| eslint-plugin/tests/lib/rules/no-multiple-style-changes.js | Reformatted test cases to use multiline template literals for clarity |
utarwyn
force-pushed
the
fix-66-style-changes-error
branch
from
df7f0c4 to
cd09989
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the rule
@creedengo/no-multiple-style-changes(GCI12) to avoid triggering an exception when it executes on a specific piece of code without expression. This occurs when linting Next server code for example.Fixes #66