Skip to content

Conversation

@ajlee21
Copy link
Contributor

@ajlee21 ajlee21 commented Jan 8, 2021

The goal of this PR was to add other multiple enrichment methods to demonstrate the our simulation method can be plugged into other pipelines easily.

These changes were started in a previous PR, but was prematurely closed due to other changes that this PR depended on.

This PR has the following changes:

  1. Add new script other_enrichment_methods.R to run other enrichment analysis methods
  2. Add directory with notebooks to simulate data and run different enrichment analyses other_enrichment_methods/
  3. Updated previous scripts, analysis and test notebooks to allow for an additional parameter for user to specify enrichment method.

@ajlee21 ajlee21 marked this pull request as ready for review January 18, 2021 15:19
@ajlee21 ajlee21 requested a review from jjc2718 January 18, 2021 20:06
Copy link
Contributor

@jjc2718 jjc2718 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! My main point of confusion is just trying to figure out what the plots mean in 3_viz_pathway_ranking.ipynb, but otherwise everything seems fine to me.

@ajlee21 ajlee21 merged commit f44dc7b into greenelab:master Jan 21, 2021
@ajlee21 ajlee21 deleted the add_enrich branch January 21, 2021 22:44
@ajlee21 ajlee21 mentioned this pull request Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants