-
Notifications
You must be signed in to change notification settings - Fork 6
Add enrichment analyses #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update recount2 volcano plot * add new template files for each recount2 template id * add new notebook to compare trends generated using two different template experiments * update figure after rerun simulation * clean up notebook comments * update fig generation based on comments * update comment about custom legend in plotting * update notebook based on PR
jjc2718
approved these changes
Jan 21, 2021
Contributor
jjc2718
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! My main point of confusion is just trying to figure out what the plots mean in 3_viz_pathway_ranking.ipynb, but otherwise everything seems fine to me.
Co-authored-by: Jake Crawford <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR was to add other multiple enrichment methods to demonstrate the our simulation method can be plugged into other pipelines easily.
These changes were started in a previous PR, but was prematurely closed due to other changes that this PR depended on.
This PR has the following changes:
other_enrichment_methods.Rto run other enrichment analysis methodsother_enrichment_methods/