Skip to content

Conversation

basseche
Copy link
Contributor

@basseche basseche commented Dec 26, 2024

@basseche basseche requested a review from ghazwarhili December 30, 2024 12:54
@basseche basseche self-assigned this Dec 30, 2024
</Grid>
<ErrorInput name={FieldConstants.CASE_FILE} InputField={FieldErrorAlert} />
<UploadNewCase />
<UploadNewCase isNewStudyCreation />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add isNewStudyCreation to the create-case-dialog? The UploadNewCase component is shared between case and study, and this variable is used to distinguish between the two.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

const currentCaseName = getValues(name);

if (caseName) {
if (caseName && caseName !== currentCaseName) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

caseName = basename + extension (PtFige-20241120-1520-enrichi_N1.zip )
currentCaseName = basename (PtFige-20241120-1520-enrichi_N1)

caseName !== currentCaseName is always true.

Copy link
Contributor Author

@basseche basseche Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes you are right. I wanted only to check if file doesn't change (we select the same file)

@basseche
Copy link
Contributor Author

basseche commented Jan 6, 2025

suggestion to fix this PR

The problem with this fix that :

  • it will introduce a bug, because it doesn't take into account user modification of the name, it will always calls endPoint.
  • it does not solve problem of UniqueNameInput component.
  • it is a refactoring it will make PrefilledNameInput component obsolete and we should remove it.

@basseche basseche requested a review from ghazwarhili January 6, 2025 08:03
@ghazwarhili
Copy link
Contributor

I didn't say this is the final solution.. it's a proposal or suggestion to properly implement the new endpoint, like a first version to be completed.

@basseche basseche closed this Jan 8, 2025
@basseche basseche reopened this Jan 9, 2025
Copy link

sonarqubecloud bot commented Jan 9, 2025

@basseche basseche merged commit 55cdbde into main Jan 14, 2025
5 checks passed
@basseche basseche deleted the case_base_name branch January 14, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants