-
Notifications
You must be signed in to change notification settings - Fork 1
Case import : compute base name from case-server instead of front com… #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6e98cb9
to
cc364e6
Compare
cc364e6
to
dbe71f5
Compare
</Grid> | ||
<ErrorInput name={FieldConstants.CASE_FILE} InputField={FieldErrorAlert} /> | ||
<UploadNewCase /> | ||
<UploadNewCase isNewStudyCreation /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you add isNewStudyCreation to the create-case-dialog? The UploadNewCase component is shared between case and study, and this variable is used to distinguish between the two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
const currentCaseName = getValues(name); | ||
|
||
if (caseName) { | ||
if (caseName && caseName !== currentCaseName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
caseName = basename + extension (PtFige-20241120-1520-enrichi_N1.zip )
currentCaseName = basename (PtFige-20241120-1520-enrichi_N1)
caseName !== currentCaseName is always true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes you are right. I wanted only to check if file doesn't change (we select the same file)
The problem with this fix that :
|
I didn't say this is the final solution.. it's a proposal or suggestion to properly implement the new endpoint, like a first version to be completed. |
|
needs :
gridsuite/commons-ui#661