Correction for case base name #592
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem with this fix that :
|
thangqp
reviewed
Jan 8, 2025
|
|
||
| const activeDirectory = useSelector((state: AppState) => state.activeDirectory); | ||
| const userId = useSelector((state: AppState) => state.user?.profile.sub); | ||
| const [modifiedByUser, setModifiedByUser] = useState(false); |
There was a problem hiding this comment.
Suggested change
| const [modifiedByUser, setModifiedByUser] = useState(false); | |
| const [nameModifiedByUser, setNameModifiedByUser] = useState(false); |
thangqp
reviewed
Jan 8, 2025
| const MAX_FILE_SIZE_IN_BYTES = MAX_FILE_SIZE_IN_MO * 1024 * 1024; | ||
|
|
||
| export default function UploadNewCase({ | ||
| modifiedByUser = false, |
There was a problem hiding this comment.
Suggested change
| modifiedByUser = false, | |
| nameModifiedByUser = false, |
|
basseche
reviewed
Jan 8, 2025
| getBaseName(currentCaseFileName) | ||
| .then((response) => { | ||
| setValue(name, response, { | ||
| shouldValidate: true, |
There was a problem hiding this comment.
you should not use shouldValidate : true, it will removes check on duplicate name
basseche
requested changes
Jan 8, 2025
basseche
reviewed
Jan 8, 2025
| const selectedDirectory = useSelector((state: AppState) => state.selectedDirectory); | ||
| const userId = useSelector((state: AppState) => state.user?.profile.sub); | ||
|
|
||
| const [modifiedByUser, setModifiedByUser] = useState(false); |
There was a problem hiding this comment.
it is not a good thing to put the state of the child here, you render the whole form when the state of the child changes !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
suggestion to fix this PR