Conform RPCError to RPCErrorConvertible #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
requested changes
Jul 1, 2025
Sources/GRPCCore/RPCError.swift
Outdated
| } | ||
| } | ||
|
|
||
| @available(gRPCSwift 2.0, *) |
There was a problem hiding this comment.
Suggested change
| @available(gRPCSwift 2.0, *) | |
| @available(gRPCSwift 2.1, *) |
Comment on lines
+354
to
+355
| } | ||
| } |
There was a problem hiding this comment.
Can you add the metadata and cause as well? They're defaulted on the protocol but we shouldn't drop them on the floor.
|
Looks like you'll need to run the formatter too ( |
glbrntt
approved these changes
Jul 1, 2025
dongjoon-hyun
added a commit
to apache/spark-connect-swift
that referenced
this pull request
Aug 26, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `grpc-swift-2` to 2.1.0. ### Why are the changes needed? To bring the latest improvements and bug fixes. - https://github.com/grpc/grpc-swift-2/releases/tag/2.1.0 - grpc/grpc-swift-2#4 - grpc/grpc-swift-2#3 - grpc/grpc-swift-2#7 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #231 from dongjoon-hyun/SPARK-52913. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6