Skip to content

Conform RPCError to RPCErrorConvertible #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025
Merged

Conform RPCError to RPCErrorConvertible #7

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d544baf
Conform RPCError to RPCErrorConvertible
0xTim Jul 1, 2025
0a2adb9
Add metadata and cause
0xTim Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Sources/GRPCCore/RPCError.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,3 +342,14 @@ extension RPCError {
self.cause = convertible.rpcErrorCause
}
}

@available(gRPCSwift 2.0, *)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@available(gRPCSwift 2.0, *)
@available(gRPCSwift 2.1, *)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

extension RPCError: RPCErrorConvertible {
public var rpcErrorCode: Code {
self.code
}

public var rpcErrorMessage: String {
self.message
}
}
Comment on lines +362 to +363
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the metadata and cause as well? They're defaulted on the protocol but we shouldn't drop them on the floor.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Loading