Open
Conversation
Motivation: Prior to swift-nio-http2 1.42.0 setting the target window size set both the connection and stream target window size. As of 1.42.0 the target window sizes for connection and stream are set separately. In gRPC we only have one option for configuring the window size which now only sets the stream window size, this is a slight behaviour change and we should restore the previous behaviour. In the fullness of time we should offer separate config options for stream and connection window sizes. Modifications: - Set the target window size on the connection and stream Result: Previous behaviour is restored
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Prior to swift-nio-http2 1.42.0 setting the target window size set both the connection and stream target window size.
As of 1.42.0 the target window sizes for connection and stream are set separately. In gRPC we only have one option for configuring the window size which now only sets the stream window size, this is a slight behaviour change and we should restore the previous behaviour.
In the fullness of time we should offer separate config options for stream and connection window sizes.
Modifications:
Result:
Previous behaviour is restored