Skip to content

Set connection target window size #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
glbrntt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Set connection target window size #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ let dependencies: [Package.Dependency] = [
),
.package(
url: "https://github.com/apple/swift-nio-http2.git",
from: "1.38.0"
from: "1.42.0"
),
.package(
url: "https://github.com/apple/swift-nio-transport-services.git",
Expand Down
2 changes: 2 additions & 0 deletions Sources/GRPCNIOTransportCore/Internal/NIOChannelPipeline+GRPC.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ extension ChannelPipeline.SynchronousOperations {
let clampedMaxFrameSize = self.clampMaxFrameSize(http2Config.maxFrameSize)

var http2HandlerConnectionConfiguration = NIOHTTP2Handler.ConnectionConfiguration()
http2HandlerConnectionConfiguration.targetWindowSize = clampedTargetWindowSize
var http2HandlerHTTP2Settings = HTTP2Settings([
HTTP2Setting(parameter: .initialWindowSize, value: clampedTargetWindowSize),
HTTP2Setting(parameter: .maxFrameSize, value: clampedMaxFrameSize),
Expand Down Expand Up @@ -137,6 +138,7 @@ extension ChannelPipeline.SynchronousOperations {
// Use NIOs defaults as a starting point.
var http2 = NIOHTTP2Handler.Configuration()
http2.stream.targetWindowSize = clampedTargetWindowSize
http2.connection.targetWindowSize = clampedTargetWindowSize
http2.connection.initialSettings = [
// Disallow servers from creating push streams.
HTTP2Setting(parameter: .enablePush, value: 0),
Expand Down
Loading