Skip to content

Fix issue 1805 #1807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 5, 2025
Merged

Fix issue 1805 #1807

merged 6 commits into from
Sep 5, 2025

Conversation

zeroy0410
Copy link

fix #1805

sdroege
sdroege reviewed Sep 5, 2025
View reviewed changes
sdroege
sdroege reviewed Sep 5, 2025
View reviewed changes
sdroege
sdroege requested changes Sep 5, 2025
View reviewed changes
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you split this into 6 separate commits (in the same PR) for the individual, unrelated issues? Each of them with a commit message explaining what is done there (basically what you already wrote in the issue, possibly shortened a bit)

@zeroy0410
Copy link
Author

Can you split this into 6 separate commits (in the same PR) for the individual, unrelated issues? Each of them with a commit message explaining what is done there (basically what you already wrote in the issue, possibly shortened a bit)

I have followed your instructions and completed the task : )

@zeroy0410 zeroy0410 requested a review from sdroege September 5, 2025 12:50
@sdroege sdroege merged commit 3e24857 into gtk-rs:main Sep 5, 2025
48 checks passed
@sdroege
Copy link
Member

sdroege commented Sep 5, 2025

Thanks!

@sdroege sdroege added the needs-backport PR needs backporting to the current stable branch label Sep 5, 2025
@sdroege sdroege added backported PR was backported to the current stable branch and removed needs-backport PR needs backporting to the current stable branch labels Sep 17, 2025
sdroege
sdroege reviewed Sep 21, 2025
View reviewed changes
pango/src/functions.rs
"start_index is out of range"
);
assert!(
length >= 0 && start_index.checked_add(length).unwrap() < total_length,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong unfortunately, sorry for missing that. Needs to be <= total_length.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdroege sdroege sdroege approved these changes

Assignees

No one assigned

Labels

backported PR was backported to the current stable branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Comprehensive Report] Multiple Soundness and Logical Issues Found in Rust FFI Wrappers

2 participants

@zeroy0410 @sdroege