Skip to content

Do not render subnav for interactive articles#14269

Merged
jonathonherbert merged 1 commit intomainfrom
jsh/no-subnav-for-interactives
Jul 23, 2025
Merged

Do not render subnav for interactive articles#14269
jonathonherbert merged 1 commit intomainfrom
jsh/no-subnav-for-interactives

Conversation

@jonathonherbert
Copy link
Contributor

@jonathonherbert jonathonherbert commented Jul 23, 2025

What does this change?

Following feedback after #14242, remove the subnav as well, to match the layout for immersives.

Why?

Feedback from the relevant teams.

Screenshots

Before After Immersive
before after immersive

@jonathonherbert jonathonherbert force-pushed the jsh/no-subnav-for-interactives branch from 8b63980 to ec13d9a Compare July 23, 2025 13:06
@github-actions
Copy link

github-actions bot commented Jul 23, 2025

@jonathonherbert jonathonherbert force-pushed the jsh/no-subnav-for-interactives branch 2 times, most recently from 3fdaf1a to 9f8a192 Compare July 23, 2025 13:19
@github-actions
Copy link

github-actions bot commented Jul 23, 2025

@jonathonherbert jonathonherbert marked this pull request as ready for review July 23, 2025 13:57
@github-actions
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@jonathonherbert jonathonherbert force-pushed the jsh/no-subnav-for-interactives branch from 9f8a192 to 5eabfec Compare July 23, 2025 13:57
@jonathonherbert jonathonherbert added the run_chromatic Runs chromatic when label is applied label Jul 23, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jul 23, 2025
Copy link
Contributor

@KaliedaRik KaliedaRik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very approved!

@jonathonherbert jonathonherbert merged commit c9cabe5 into main Jul 23, 2025
31 checks passed
@jonathonherbert jonathonherbert deleted the jsh/no-subnav-for-interactives branch July 23, 2025 14:23
@prout-bot
Copy link

Seen on PROD (merged by @jonathonherbert 11 minutes and 13 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants