Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
abeddow91
force-pushed
the
ab/tag-page-formatting
branch
from
c0fadec to
c1d794d
Compare
abeddow91
force-pushed
the
ab/tag-page-formatting
branch
from
c1d794d to
8672ea9
Compare
domlander
approved these changes
Jul 23, 2025
Contributor
|
I'm not sure how easy it is to find, but what elements does frontend support? If DCR achieves parity with frontend, then I think we can close #11930 |
github-actions
bot
removed
the
run_chromatic
|
Seen on PROD (merged by @abeddow91 11 minutes and 29 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Add 4px margin at the bottom of
<p>tags and adds styling to some tags that are nested within paragraphs such as bold, strong and italic tags.This is achieved by extending the element tree builder so that it explicitly recognises P tags and styling to them. It resolves #11930 but it is not an exhaustive list of tags so it is possible this will need to be extended further if additional nodes are nested. We can address these as and when they arise.
Why?
To create a visual distinction in the description of a tag page header.
Screenshots