Skip to content

Tag Page <p> styling #14270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abeddow91 merged 3 commits into from
Jul 24, 2025
Merged

Tag Page <p> styling #14270

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3698be2
Add 4px padding at the bottom of <p> tags.
abeddow91 Jul 23, 2025
f70e4ec
Add styling for strong, bold, and i tags
abeddow91 Jul 23, 2025
8672ea9
Prefer margin-bottom over padding bottom
abeddow91 Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions dotcom-rendering/src/components/TagPageHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ const titleContainerStyle = css`
`;

const paragraphStyle = css`
${headlineMedium17}
${headlineMedium17};
color: ${palette.neutral[46]};
`;

Expand All @@ -208,6 +208,19 @@ const linkStyles = css`
border-bottom: 1px solid ${palette.brand[500]};
`;

const pStyles = css`
margin-bottom: ${space[1]}px;
b,
strong em,
strong u {
font-weight: bold;
}

i {
font-style: italic;
}
`;

const buildElementTree = (node: Node): ReactNode => {
if (isElement(node)) {
switch (node.nodeName) {
Expand All @@ -220,6 +233,11 @@ const buildElementTree = (node: Node): ReactNode => {
});
case 'BR':
return jsx('br');
case 'P':
return jsx('p', {
css: pStyles,
children: Array.from(node.childNodes).map(buildElementTree),
});
default:
return jsx(node.tagName.toLowerCase(), {
children: Array.from(node.childNodes).map(buildElementTree),
Expand Down Expand Up @@ -278,7 +296,6 @@ export const TagPageHeader = ({ title, description, image }: Props) => {
const descriptionFragment = description
? parseHtml(description)
: undefined;

return (
<section css={[fallbackStyles, containerStyles]}>
<div css={[decoration, sideBorders]} />
Expand Down