Skip to content

Scrollable highlights colours#14295

Merged
domlander merged 4 commits intomainfrom
doml/scrollable-highlights-colours
Aug 6, 2025
Merged

Scrollable highlights colours#14295
domlander merged 4 commits intomainfrom
doml/scrollable-highlights-colours

Conversation

@domlander
Copy link
Contributor

@domlander domlander commented Jul 28, 2025 •
edited
Loading

What does this change?

Updates the Scrollable Highlight container:

  • Matches the colours currently used on apps (includes dark mode tweak)
  • Updates spacing
  • Reduces image size from 112px to 98px to compensate for extra spacing
  • Updates the format on tablet breakpoints to use the desktop styles rather than mobile

Why?

To match Figma designs.

Screenshots

Before After
mobile mobile-before mobile-after
tablet tablet-before tablet-after
desktop desktop-before desktop-after
Before After
mobile dark-mobile-before dark-mobile-after
desktop dark-desktop-before dark-desktop-after

@domlander domlander self-assigned this Jul 28, 2025
@github-actions
Copy link

github-actions bot commented Jul 28, 2025 •
edited
Loading

Deploy build 44335 of Mobile::mobile-apps-rendering to CODE

All deployment options

From guardian/actions-riff-raff.

@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Jul 28, 2025
@github-actions
Copy link

github-actions bot commented Jul 28, 2025 •
edited
Loading

Deploy build 20109 of dotcom:rendering-all to CODE

All deployment options

From guardian/actions-riff-raff.

@domlander domlander mentioned this pull request Jul 29, 2025
Merged
@domlander domlander force-pushed the doml/scrollable-highlights-colours branch from 8f983a7 to 5bcae9c Compare July 29, 2025 12:53
@domlander domlander force-pushed the doml/scrollable-highlights-colours branch from 5bcae9c to 32a0b30 Compare August 4, 2025 09:51
@domlander domlander added run_chromatic Runs chromatic when label is applied and removed Do not merge ⚠️ labels Aug 4, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Aug 4, 2025
@domlander domlander marked this pull request as ready for review August 4, 2025 11:08
@github-actions
Copy link

github-actions bot commented Aug 4, 2025

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@domlander domlander added the run_chromatic Runs chromatic when label is applied label Aug 4, 2025
@domlander domlander requested a review from abeddow91 August 4, 2025 11:08
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Aug 4, 2025
@domlander domlander force-pushed the doml/scrollable-highlights-colours branch from 78322db to d235948 Compare August 4, 2025 14:26
abeddow91
abeddow91 approved these changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@abeddow91 abeddow91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Happy to see the move to flex on the card - much simpler.

@domlander domlander added the run_chromatic Runs chromatic when label is applied label Aug 6, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Aug 6, 2025
@domlander domlander merged commit ff00dc7 into main Aug 6, 2025
31 checks passed
@domlander domlander deleted the doml/scrollable-highlights-colours branch August 6, 2025 13:53
@prout-bot
Copy link

prout-bot commented Aug 6, 2025

Seen on PROD (merged by @domlander 9 minutes and 22 seconds ago) Please check your changes!

@domlander domlander added the maintenance Departmental tracking: maintenance work, not a fix or a feature label Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abeddow91 abeddow91 abeddow91 approved these changes

Assignees

@domlander domlander

Labels

dotcom-rendering fronts + curation maintenance Departmental tracking: maintenance work, not a fix or a feature Seen-on-PROD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@domlander @prout-bot @abeddow91