Conversation
deedeeh
force-pushed
the
md/insert-galleries-ads
branch
from
bc5212c to
8ecd2ce
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
deedeeh
force-pushed
the
md/insert-galleries-ads
branch
from
8ecd2ce to
c3036a6
Compare
Contributor
Author
Thank you Charlotte |
deedeeh
force-pushed
the
md/insert-galleries-ads
branch
from
fd7e504 to
4d9ab48
Compare
Co-authored-by: Marjan Kalanaki <marjan.kalanaki@guardian.co.uk>
Co-authored-by: Marjan Kalanaki <marjan.kalanaki@guardian.co.uk>
Co-authored-by: Marjan Kalanaki <marjan.kalanaki@guardian.co.uk>
Co-authored-by: Dina Hafez <dina.hafez@guardian.co.uk>
Co-authored-by: Dina Hafez <dina.hafez@guardian.co.uk>
…n mobile plus refactoring
deedeeh
force-pushed
the
md/insert-galleries-ads
branch
from
e057695 to
18f1e74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR inserts ads in Galleries DCR. Check issue #12293
The changes includes:
top-above-navslot for desktop which appears as the first element on the page.top-above-nav--mobileas the first slot in the body of the Gallery and theninline1,inline2, etc... for mobile which still renders after every 4 images similar to desktop.merchandising-highfor mobile and desktop but in the Labs Galleries migration we are not showing this slot so I already added the condition for it in this PR.merchandisingfor mobile and desktop. Also not showing in Labs Galleries after migration.At the moment
merchandising-highandmerchandisingare stacked because the "Related stories" and "Most popular" containers are not added yet.All the screenshots are captured in light mode because we are still haven't worked on ads in App. That will be next step after we are done with Web.
To-do:
most-popslot for desktop which should be added as part of the "Most popular" container. We don't show it for mobile breakpoint. See hide mostpop ad slot #9642Why?
This is part of the Galleries migration from Frontend to DCR.
Screenshots