AB test: Every card on the network front is boosted#14509
Conversation
domlander
force-pushed
the
doml/all-boosts
branch
from
2338455 to
daf7cc2
Compare
domlander
force-pushed
the
doml/all-boosts
branch
from
daf7cc2 to
d9bec50
Compare
domlander
force-pushed
the
doml/all-boosts
branch
from
d9bec50 to
f533696
Compare
domlander
force-pushed
the
doml/all-boosts
branch
from
f533696 to
7ca9dea
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
| return isInAllBoostsTest ? ( | ||
| <ScrollableSmall | ||
| trails={trails} | ||
| imageLoading={imageLoading} | ||
| containerPalette={containerPalette} | ||
| showAge={showAge} | ||
| absoluteServerTimes={absoluteServerTimes} | ||
| aspectRatio={aspectRatio} | ||
| isInAllBoostsTest={true} | ||
| sectionId={sectionId} | ||
| showLabsRedesign={!!showLabsRedesign} | ||
| /> | ||
| ) : ( | ||
| <Island priority="feature" defer={{ until: 'visible' }}> | ||
| <ScrollableSmall | ||
| trails={trails} | ||
| imageLoading={imageLoading} | ||
| containerType={'scrollable/small'} | ||
| containerPalette={containerPalette} | ||
| showAge={showAge} | ||
| absoluteServerTimes={absoluteServerTimes} | ||
| aspectRatio={aspectRatio} | ||
| isInAllBoostsTest={false} | ||
| sectionId={sectionId} | ||
| showLabsRedesign={!!showLabsRedesign} | ||
| /> | ||
| </Island> |
There was a problem hiding this comment.
We do not have carousels when in the AB test, so we don't need the javascript that comes with carousels.
| showAge: true, | ||
| absoluteServerTimes: true, | ||
| imageLoading: 'eager', | ||
| containerType: 'scrollable/medium', |
There was a problem hiding this comment.
Is defined within ScrollableMedium component so no longer needs to be passed through?
There was a problem hiding this comment.
This might be easier to review by looking at the first commit in this PR. Where the containerType is used, it's the name of the container. It's confusing for a ScrollableMedium container to have containerType equal to scrollable/small, which it was before when it was passed in through DecideContainer.tsx. I did miss a usage of this containerType in the Card component, which I'll push in a separate commit.
| return ( | ||
| <> | ||
| <UL direction="row" padBottom={true}> | ||
| {trails.slice(0, 2).map((trail, index) => { |
There was a problem hiding this comment.
What's the slicing for here?
There was a problem hiding this comment.
ScrollableSmall containers have four cards in two rows of two
| collectionId={index + 1} | ||
| isInAllBoostsTest={ | ||
| front.isNetworkFront && | ||
| abTests.allBoostsVariant !== 'variant' |
There was a problem hiding this comment.
Just double checking this is the right way round?
There was a problem hiding this comment.
Nope! I'd left this is accidentally from testing. Thanks for catching
|
Seen on PROD (merged by @domlander 7 minutes and 47 seconds ago) Please check your changes! |
2 participants
What does this change?
Creates an AB test that will set every card in one of the following containers on mobile web to boosted:
Feature cards are excluded from this test.
Small refactor so that scrollable medium no longer has the container type: "scrollable/small". This could use a follow-up refactor after this test has finished, as i'm not sure it makes sense for scrollable medium cards to be small cards.
Why?
To find our the effect on clickthrough rate when every card is boosted
Screenshots