Skip to content

Conversation

@Jakeii
Copy link
Member

@Jakeii Jakeii commented Oct 13, 2025

Why?

The UI isn't being deployed at the moment.

Using a second riff-raff.yaml with the same project name isn't working, I've moved the ab-test UI deploy into the main CICD workflow and rif-raff.yaml

Update with a new riff-raff project name, and it's working now.

@Jakeii Jakeii force-pushed the jlk/update-ab-test-ui-deploy branch from 95c7c97 to e123eac Compare October 13, 2025 14:43
@Jakeii Jakeii force-pushed the jlk/update-ab-test-ui-deploy branch from e123eac to e332043 Compare October 13, 2025 14:44
@github-actions
Copy link

github-actions bot commented Oct 13, 2025

@Jakeii Jakeii force-pushed the jlk/update-ab-test-ui-deploy branch 3 times, most recently from 1577e4e to 7b5c6e1 Compare October 13, 2025 14:55
@github-actions
Copy link

github-actions bot commented Oct 13, 2025

@Jakeii Jakeii force-pushed the jlk/update-ab-test-ui-deploy branch from 7b5c6e1 to 1d9441e Compare October 13, 2025 15:02
@Jakeii Jakeii marked this pull request as ready for review October 14, 2025 09:13
@Jakeii Jakeii requested a review from a team as a code owner October 14, 2025 09:13
@github-actions
Copy link

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@Jakeii Jakeii requested a review from a team October 14, 2025 09:14
@Jakeii Jakeii added run_chromatic Runs chromatic when label is applied fix labels Oct 14, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Oct 14, 2025
Copy link
Contributor

@cemms1 cemms1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll need to set up a new riffraff project for this as it's not related to rendering pages so shouldn't be too linked to dotcom-rendering as a concept

Comment on lines 29 to 35
admin/ab-testing:
type: aws-s3
parameters:
bucketSsmKey: /account/services/dotcom-store.bucket
cacheControl: public, max-age=315360000
prefixStack: false
publicReadAcl: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should go in the dotcom-rendering directory

@Jakeii
Copy link
Member Author

Jakeii commented Oct 14, 2025

I think we'll need to set up a new riffraff project for this as it's not related to rendering pages so shouldn't be too linked to dotcom-rendering as a concept

Okay yes, I felt it was okay as it's all to do with serving things on the site, but you're right it's not to do with rendering the content.

@Jakeii Jakeii changed the title use main riff-raff for ab-testing ui deploy Use new seperate project name for ab-testing UI riff-raff deploy Oct 14, 2025
@Jakeii Jakeii added the run_chromatic Runs chromatic when label is applied label Oct 14, 2025
@github-actions github-actions bot removed the run_chromatic Runs chromatic when label is applied label Oct 14, 2025
@Jakeii Jakeii merged commit 85284e5 into main Oct 15, 2025
40 of 41 checks passed
@Jakeii Jakeii deleted the jlk/update-ab-test-ui-deploy branch October 15, 2025 09:17
@gu-prout
Copy link

gu-prout bot commented Oct 15, 2025

Seen on PROD (merged by @Jakeii 8 minutes and 58 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Departmental tracking: fix Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants