-
Notifications
You must be signed in to change notification settings - Fork 30
Use new seperate project name for ab-testing UI riff-raff deploy #14674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
95c7c97 to
e123eac
Compare
e123eac to
e332043
Compare
1577e4e to
7b5c6e1
Compare
7b5c6e1 to
1d9441e
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
cemms1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll need to set up a new riffraff project for this as it's not related to rendering pages so shouldn't be too linked to dotcom-rendering as a concept
| admin/ab-testing: | ||
| type: aws-s3 | ||
| parameters: | ||
| bucketSsmKey: /account/services/dotcom-store.bucket | ||
| cacheControl: public, max-age=315360000 | ||
| prefixStack: false | ||
| publicReadAcl: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should go in the dotcom-rendering directory
Okay yes, I felt it was okay as it's all to do with serving things on the site, but you're right it's not to do with rendering the content. |
Why?
The UI isn't being deployed at the moment.
Using a second riff-raff.yaml with the same project name isn't working, I've moved the ab-test UI deploy into the main CICD workflow and rif-raff.yamlUpdate with a new riff-raff project name, and it's working now.