Update spacing between card/container and branding labels#14679
Merged
Conversation
cemms1
changed the title
cemms1
force-pushed
the
cemms1/update-branding-spacing
branch
from
8d7d6e2 to
9776303
Compare
cemms1
commented
Oct 14, 2025
| /** When we hover on sublinks, we want to prevent the general hover styles applying */ | ||
| const sublinkHoverStyles = css` | ||
| :has(ul.sublinks:hover) { | ||
| :has(ul.sublinks:hover, .branding-logo:hover) { |
Contributor
Author
There was a problem hiding this comment.
Drive by fix: this prevents the main card hover styles applying when hovering over the branding logo (which has a different destination URL)
github-actions
bot
removed
the
run_chromatic
deedeeh
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates the spacing above the
SponsoredContentLabelto be${space[2]}px(or 8px) in all scenariosThis is used in new style Labs containers (currently behind a feature flag or available via opting into an experiment)
Why?
Requested follow-up to the design updates for Labs containers
Screenshots