Add group to frontend and dcar match summary page data models #15079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marjisound
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR
FEFootballMatchPagewith a new fieldgroupFEGroupSummary&FELeagueTableEntrySummaryto remove results from entryFootballTableSummary&EntrySummaryThis is because for the new design of the match info (summary) page, we need to include a summary of the league table group rather than the whole league table. Also to optimise performance and payload size, the new *Summary types explicitly exclude detailed match results, as they are not required for this view.
The frontend PR for this guardian/frontend#28495
Test
This was tested locally and in code. Currently it doesn't have any impact on the page since the new component
FootballMatchInfois not yet wired up within the pagesThis PR fixes part of #14904