Add league tables data to the football match info endpoints #28495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
marjisound
changed the title
marjisound
force-pushed
the
add-league-tables-to-football-match-endpoints
branch
from
176b58b to
11f5432
Compare
gu-prout
bot
added
Pending-on-ADMIN-PROD
Pending-on-FRONTS-PROD
Seen-on-ADMIN-PROD
and removed
Pending-on-ADMIN-PROD
labels
|
Seen on ADMIN-PROD (merged by @marjisound 26 minutes and 14 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @marjisound 28 minutes and 24 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
This PR updates the data model for
dotcomRenderingFootballMatchSummaryDataModelwith the league table group the match is in. This data model affects the following endpoints:Why not include the whole league table:
The DCAR match summary page only requires the context of the specific group the teams are in, not the entire league table.
For competitions with multiple groups (e.g. World Cup, Champions League), the full league table data payload can become very large. Sending only the relevant group prevents unnecessary performance degradation.
Detailed team results within the group entries are not required for these summary pages, so they have been excluded to further reduce payload size.
The DCAR PR for this guardian/dotcom-rendering#15079
The result look like this:
This PR fixes part of #14904