Merged
Conversation
juabara
approved these changes
Oct 10, 2025
tomrf1
reviewed
Oct 13, 2025
src/shared/types/reminders.ts
Outdated
| @@ -1,18 +1,5 @@ | |||
| export type ReminderPlatform = 'WEB' | 'AMP'; | |||
| export type ReminderPlatform = 'WEB'; | |||
Member
There was a problem hiding this comment.
this file is only used by ampEpicRouter.ts, so we can delete all of this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
The goal of this PR is to remove the logic around AMP epics. AMP (Accelerated Mobile Pages) is an open source framework used for accelerating page loading but since Google is no longer using it as a ranking factor and because of other reasons it needs to be removed. More detailed explanation is here.
How to test
The following API requests will not be available after merge of this MR:
get /amp/experiments_data
post /amp/set_reminder
get /amp/epic
get /amp/epic_view
All the other API should continue to work as expected. TBD - test locally and in other envs.
How can we measure success?
Have we considered potential risks?
Images
Accessibility