Fix extraVolumeMounts; fix double mount in existingVolumeClaim; document existingVolumeClaim#190
Open
lkvrsfld wants to merge 2 commits intoguerzon:mainfrom
Open
Fix extraVolumeMounts; fix double mount in existingVolumeClaim; document existingVolumeClaim#190lkvrsfld wants to merge 2 commits intoguerzon:mainfrom
lkvrsfld wants to merge 2 commits intoguerzon:mainfrom
Conversation
Author
|
needs to be tested outside of helm template |
11 tasks
|
superseeded by #196 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the storage.existingVolumeClaim option mounting the same volume on both '/data' and '/data/attachments', which breaks downloading attachments.
it also removes the option 'storage.existingVolumeClaim.attachmentsPath', and documents how to restore from existing PVCs when having data and attachments in different volumes /PVCs.
It also removes extraVolumeMounts from being only applied when existingVolumeClaim exists - this makes it possible, to use the 'storage.data' and 'storage.attachment' options together with extraVolumeMounts.