Fix extraVolumes duplicate volumes key (#189) and existingVolumeClaim double-mount (#139)#196
Open
IQNeoXen wants to merge 1 commit intoguerzon:mainfrom
Open
Fix extraVolumes duplicate volumes key (#189) and existingVolumeClaim double-mount (#139)#196IQNeoXen wants to merge 1 commit intoguerzon:mainfrom
IQNeoXen wants to merge 1 commit intoguerzon:mainfrom
Conversation
Move all volume rendering out of _podSpec.tpl into deployment.yaml and statefulset.yaml so that PVC volumes, existingVolumeClaim, and extraVolumes are merged into a single volumes: block instead of producing duplicate YAML keys. Also fix extraVolumeMounts being ignored when storage.data is set (guerzon#139) and remove the double-mount of /data/attachments from existingVolumeClaim. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volume rendering was split across two templates:
_podSpec.tplemitted avolumes:block forexistingVolumeClaim/extraVolumes, whiledeployment.yamlemitted a separatevolumes:block for PVC-backed storage. When bothstorage.dataandextraVolumeswere set, the rendered manifest contained duplicatevolumes:keys which resulted in invalid YAML that caused silent failures.Similarly, the
volumeMountssection used an exclusive if/else that only renderedextraVolumeMountsinside theexistingVolumeClaimbranch, skipping them entirely whenstorage.datawas used.extraVolumesproducing a duplicate volumes: YAML key when used alongsidestorage.data(Volumes is defined twice for extraVolumes #189)extraVolumeMountsbeing silently ignored whenstorage.datais set instead ofexistingVolumeClaimexistingVolumeClaimdouble-mounting the same PVC at both/dataand/data/attachments(Usingstorage.existingVolumeClaimin v0.31.1 can't find existing attachments. #139)attachmentsPathoption fromexistingVolumeClaimTest Plan (also auto-generated by Opus):
Caution
This fix was developed using Claude Code with Opus 4.6. Claude Code performed the root cause analysis across the Helm templates, implemented the fix, and ran the full test matrix against helm template and helm lint. All changes were reviewed and validated by me (@IQNeoXen) before submission though :)
storage.existingVolumeClaimin v0.31.1 can't find existing attachments. #139